fix: fixes datepicker issue within dataviz (M2-7348)

[ramirlm]

📝 Description

🔗 Jira Ticket M2-7348

Dates without responses were being auto-selected, and the actual response day could not be selected. This behavior is being fixed and now the view loads the days correctly.

Changes include:

• Fixes for the calendar picker on Dataviz, interpolating a UTC 00:00 time into the date in order to avoid gaps

🪤 Peer Testing

• Create an applet, and add responses to it

• Open the participant view, click on responses

• Check if the responses are showing on the correct day

• Click on any response, and check if it opens correctly

  Expected outcome: The responses are loading on the correct days, and the days without response are not being able to be selected

  The updated code only shows selectable options where the limited user has inputted answers for that activity, for that subject:

✏️ Notes

• Backend changes for this task were not necessary

[aws-amplify-us-east-1]

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1987.d19gtpld8yi51u.amplifyapp.com

[farmerpaul]

We don't actually need activity ID to be defined as it's an optional parameter to getAppletSubmitDateList (but open to hearing your thoughts).

Suggested change

	if (!appletId || !subjectId || !selectedActivity?.id) return;
	if (!appletId || !subjectId) return;

[ramirlm]

This was necessary to make sure the method in the api is being called with a non-empty value for activityOrFlowId @farmerpaul

[farmerpaul]

I'm not sure we should be restricting the handleGetSubmitDates to only instances of this screen where an activity has been selected. The RespondentDataReview screen is accessible in the app from several routes, including a route that doesn't include either an activity ID or flow ID as a parameter:

mindlogger-admin/src/modules/Dashboard/routes/routes.tsx

Lines 136 to 147 in c1ba765

	<Route path={page.appletParticipantDataReview} element={<RespondentDataReview />}>
	<Route
	path={page.appletParticipantDataReview}
	element={
	<PrivateRoute>
	<ErrorBoundary FallbackComponent={ErrorFallback}>
	<RespondentDataReview />
	</ErrorBoundary>
	</PrivateRoute>
	}
	/>
	</Route>

mindlogger-admin/src/resources/pages.json

Line 27 in a55547a

"appletParticipantDataReview": "/dashboard/:appletId/participants/:subjectId/dataviz/responses",

So it's still possible to invoke this component where activity ID or activity flow ID have not been defined. I was able to navigate to this URL after checking out your branch:

https://localhost:3000/dashboard/8e9bd4f9-7ea3-4cfd-b6b1-040108774370/participants/83b7ff36-2175-4fd0-80c7-bc9f1d08ddee/dataviz/responses

And because no default activity was selected, the handleGetSubmitDates callback was bypassed due to this condition, and resulted in a datepicker showing all dates as being available:

Now, whether the app is even supposed to still be calling this route is a separate question (I think it's deprecated), one which I think I need to bring up with product. But I think it's still accessible from a few spots, so we should probably make sure not to affect the datepicker when those routes are still being called.

So for now, I think I stand by my original suggestion of not changing this line:

Suggested change

	if (!appletId || !subjectId || !selectedActivity?.id) return;
	if (!appletId || !subjectId) return;

[farmerpaul]

I'm assuming you discovered you needed to trigger the effect when the activity ID becomes available, but shouldn't that also be true for the flow ID?

Suggested change

	}, [lastActivityCompleted, selectedActivity?.id]);
	}, [lastActivityCompleted, selectedActivity?.id, selectedFlow?.id]);

[ramirlm]

🎯 @farmerpaul

[ramirlm]

@farmerpaul FYI still ongoing fixing this – I appreciate the insights though!