Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow number select item type to be printed (M2-8147) #1644

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: Allow number select item type to be printed (M2-8147) #1644

merged 1 commit into from
Oct 30, 2024

Conversation

sultanofcardio
Copy link
Contributor

@sultanofcardio sultanofcardio commented Oct 29, 2024 •
edited
Loading

📝 Description

🔗 Jira Ticket M2-8147

This PR updates the applet validation logic to allow items of type NUMBERSELECT to be included in the report or section printed items.

🪤 Peer Testing

image

✏️ Notes

N/A

@sultanofcardio sultanofcardio self-assigned this Oct 29, 2024
@sultanofcardio sultanofcardio mentioned this pull request Oct 29, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

➡️ Preview environment failed to be destroyed

@github-actions GitHub Actions
Copy link

❌ E2E tests failed

@sultanofcardio sultanofcardio marked this pull request as ready for review October 30, 2024 12:33
@sultanofcardio sultanofcardio changed the title fix: Allow number select item type to be printed fix: Allow number select item type to be printed (M2-8147) Oct 30, 2024
mbanting
mbanting approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@mbanting mbanting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested alongside M2-8146. Code LGTM too. Thanks identifying the issue and addressing this quickly.

@sultanofcardio sultanofcardio merged commit b5462bb into release/1.8.1 Oct 30, 2024
13 of 17 checks passed
@sultanofcardio sultanofcardio deleted the fix/report-score-missing-system-items branch October 30, 2024 21:38
@mbanting mbanting mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcmerlo rcmerlo rcmerlo approved these changes

@mbanting mbanting mbanting approved these changes

@farmerpaul farmerpaul farmerpaul approved these changes

Assignees

@sultanofcardio sultanofcardio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sultanofcardio @farmerpaul @mbanting @rcmerlo