Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Greek subject translation (M2-8252) #1673

Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix: Greek subject translation (M2-8252) #1673

merged 2 commits into from
Dec 5, 2024

Conversation

ramirlm
Copy link
Contributor

@ramirlm ramirlm commented Dec 3, 2024

📝 Description

🔗 Jira Ticket M2-8252

Changes include:

  • Greek translation (and French) to the reset password subject

🪤 Peer Testing

  • Open the web app
  • Register a user(optional)
  • Select "Greek" language on top
  • Click on "Forgot password" option in Greek
  • Enter a registered email
  • Click "Αποστολή συνδέσμου επαναφοράς"

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

➡️ Preview environment failed to be destroyed

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

❌ E2E tests failed

@ramirlm ramirlm requested a review from rcmerlo December 4, 2024 00:12
rcmerlo
rcmerlo approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@rcmerlo rcmerlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! just a small sugesstion

src/apps/users/services/core.py Show resolved Hide resolved
@ramirlm ramirlm merged commit 7def9b1 into develop Dec 5, 2024
12 of 15 checks passed
@ramirlm ramirlm deleted the fix/M2-8252-greek-forgotpsswd-subject branch December 6, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcmerlo rcmerlo rcmerlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramirlm @rcmerlo