Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2-5304 Fix: Notification appears twice on the assessment page #386

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

moiskillnadne
Copy link
Contributor

@moiskillnadne moiskillnadne commented Feb 22, 2024

📝 Description

🔗 Jira Ticket M2-5304

Notification appears twice when the user passes the flow.

This PR changes:

  • Remove the notification center on the Assessment Loading Screen
  • Create assessment base layout (enhancement)

📸 Screenshots

Before

bandicam.2024-02-16.16-33-26-910.mp4

After

Screen.Recording.2024-02-22.at.17.12.55.mov

🪤 Peer Testing

  • yarn
  • yarn dev
  • Open http://localhost:5173
  • Login
  • Open the applet with the activity flow
  • Open activity flow
  • Pass the first activity
  • Submit answers
  • Have a look at the notification

✏️ Notes

@moiskillnadne moiskillnadne added Bug Something isn't working In progress Work in progress labels Feb 22, 2024
@moiskillnadne moiskillnadne self-assigned this Feb 22, 2024
@moiskillnadne moiskillnadne marked this pull request as draft February 22, 2024 05:09
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-386.d15zn9do8xbzga.amplifyapp.com

@moiskillnadne moiskillnadne marked this pull request as ready for review February 22, 2024 09:16
@moiskillnadne moiskillnadne added Done Feature or bug done and removed In progress Work in progress labels Feb 22, 2024
@moiskillnadne moiskillnadne changed the title M2-5304 Create base layout for assessment page M2-5304 Fix: Notification appears twice on the assessment page Feb 22, 2024
@moiskillnadne moiskillnadne merged commit bdeac58 into dev2.5 Feb 23, 2024
6 checks passed
@moiskillnadne moiskillnadne deleted the fix/M2-5304 branch February 23, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Done Feature or bug done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant