Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jira Tickets 2 #436

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Update Jira Tickets 2 #436

merged 1 commit into from
Apr 12, 2024

Conversation

sultanofcardio
Copy link
Contributor

@sultanofcardio sultanofcardio commented Apr 12, 2024

📝 Description

This PR updates the Update Jira Tickets GH Actions workflow to fetch all commits before determining JIRA tickets.

The current behavior is only using the most recent commit on the branch because the checkout action does a shallow clone by default. Therefore, we have to unshallow the clone in order to get all the commit messages. I decided to do it this way, instead of doing a deep clone from the outset because there are several exit points for the job that would render the deep clone unnecessary. So I do it at the point where it's needed

🪤 Peer Testing

Compare the results of the most recent release run to this manual run I just did for this PR

✏️ Notes

There's no JIRA ticket for this. It was a quick fix, so I just decided to go for it 🤷

Fetch all commits before determining JIRA tickets

The checkout action does a shallow clone by default, so we have to unshallow the clone in order to get all the commit messages.

I decided to do it this way, instead of doing a deep clone from the outset because there are several exit points for the job that would render the deep clone unnecessary. So I do it at the point where it's needed
@sultanofcardio sultanofcardio self-assigned this Apr 12, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-436.d15zn9do8xbzga.amplifyapp.com

@sultanofcardio sultanofcardio marked this pull request as ready for review April 12, 2024 10:21
@sultanofcardio sultanofcardio merged commit a4970aa into dev Apr 12, 2024
8 checks passed
@sultanofcardio sultanofcardio deleted the update-jira-tickets-2 branch April 12, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants