Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2-6042: Validate Params from Admin to Web App #438

Merged
merged 26 commits into from
Apr 25, 2024

M2-6042: Move side effects to useEffect callbacks

7207570
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

M2-6042: Validate Params from Admin to Web App #438

M2-6042: Move side effects to useEffect callbacks
7207570
Select commit
Loading
Failed to load commit list.
GitHub Actions / ESLint succeeded Apr 25, 2024 in 0s

2 warnings

ESLint found 2 warnings

Annotations

Check warning on line 18 in src/app/App.tsx

See this annotation in the file changed.

@github-actions github-actions / ESLint

src/app/App.tsx#L18 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator (@typescript-eslint/no-floating-promises)

Check warning on line 24 in src/widgets/LoginWithRedirect/index.tsx

See this annotation in the file changed.

@github-actions github-actions / ESLint

src/widgets/LoginWithRedirect/index.tsx#L24 

React Hook useEffect has missing dependencies: 'location.pathname' and 'location.search'. Either include them or remove the dependency array (react-hooks/exhaustive-deps)
View more details on GitHub Actions