-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M2-6109: [FE] [Web App] Header - Update to Include Subject and Respondent #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sultanofcardio
force-pushed
the
feature/M2-6044-submit-take-now-params
branch
from
April 24, 2024 18:23
5901022
to
127425a
Compare
sultanofcardio
force-pushed
the
feature/M2-6109-multi-informant-header
branch
from
April 24, 2024 18:35
1c0121c
to
8e56fd6
Compare
sultanofcardio
force-pushed
the
feature/M2-6044-submit-take-now-params
branch
from
April 24, 2024 20:43
127425a
to
ace3725
Compare
sultanofcardio
force-pushed
the
feature/M2-6109-multi-informant-header
branch
from
April 24, 2024 20:47
8e56fd6
to
e1a6d61
Compare
sultanofcardio
force-pushed
the
feature/M2-6044-submit-take-now-params
branch
from
April 25, 2024 05:14
ace3725
to
10598bf
Compare
sultanofcardio
force-pushed
the
feature/M2-6109-multi-informant-header
branch
from
April 25, 2024 05:16
b5d378d
to
3989f0a
Compare
sultanofcardio
force-pushed
the
feature/M2-6044-submit-take-now-params
branch
from
April 25, 2024 18:05
10598bf
to
d1271c6
Compare
sultanofcardio
force-pushed
the
feature/M2-6109-multi-informant-header
branch
from
April 25, 2024 18:07
3989f0a
to
e7dcb20
Compare
sultanofcardio
force-pushed
the
feature/M2-6109-multi-informant-header
branch
from
April 29, 2024 20:42
e7dcb20
to
15b2029
Compare
sultanofcardio
force-pushed
the
feature/M2-6109-multi-informant-header
branch
from
April 30, 2024 03:38
15b2029
to
18eca92
Compare
farmerpaul
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @sultanofcardio! Works perfectly. Just left some nitpicky 🦅 comments.
Apparently Figma doesn't account for this properly in its outputted CSS. See https://forum.figma.com/t/inspect-css-on-figma-not-aligned-with-css-when-engineer-code-out/26564
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-6109
This PR creates a
MultiInformantBadge
component that is shown during the completion of an activity in a multi-informant context. The component displays itself when the following are true:enableMultiInformant
feature flag is turned onValidateTakeNowParams
component.📸 Screenshots
Header badge with respondent hovered
Header badge with subject hovered
🪤 Peer Testing
Note
This feature depends on the
enableMultiInformant
feature flag. If it it not already enabled, you can manually enable it here like so:features.enableMultiInformant = true;
For this test, you'll need the following set up in your workspace:
An owner
A limited account participant
You will also need at least one applet with at least one activity.
Multi-Informant case
Make note of the owner user ID and the limited account participant subject ID, as well as the applet ID and activity ID. Then format them according to this URL template:
https://localhost:5173/protected/applets/{appletId}/?startActivityOrFlow={activityId}&respondentId={ownerUserId}&subjectId={limitedAccountSubjectId}
Launch that URL (and authenticate if required), then observe the activity layout. You should see the badge displayed as expected.
Regular flow
From the list of activities in the applet, launch one of the activities. You should observe that the badge is not displayed.
✏️ Notes
N/A