Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2-6109: [FE] [Web App] Header - Update to Include Subject and Respondent #442

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

sultanofcardio
Copy link
Contributor

@sultanofcardio sultanofcardio commented Apr 23, 2024

📝 Description

🔗 Jira Ticket M2-6109

This PR creates a MultiInformantBadge component that is shown during the completion of an activity in a multi-informant context. The component displays itself when the following are true:

  • The enableMultiInformant feature flag is turned on
  • The multi-informant state has been set. This state is set during the validation of multi-informant parameters in the ValidateTakeNowParams component.

📸 Screenshots

Header badge with respondent hovered

multi-informant-badge-respondent

Header badge with subject hovered

multi-informant-badge-subject

🪤 Peer Testing

Note

This feature depends on the enableMultiInformant feature flag. If it it not already enabled, you can manually enable it here like so:

features.enableMultiInformant = true;

For this test, you'll need the following set up in your workspace:

An owner
A limited account participant
You will also need at least one applet with at least one activity.

Multi-Informant case

Make note of the owner user ID and the limited account participant subject ID, as well as the applet ID and activity ID. Then format them according to this URL template:

https://localhost:5173/protected/applets/{appletId}/?startActivityOrFlow={activityId}&respondentId={ownerUserId}&subjectId={limitedAccountSubjectId}

Launch that URL (and authenticate if required), then observe the activity layout. You should see the badge displayed as expected.

Regular flow

From the list of activities in the applet, launch one of the activities. You should observe that the badge is not displayed.

✏️ Notes

N/A

@sultanofcardio sultanofcardio self-assigned this Apr 23, 2024
@sultanofcardio sultanofcardio force-pushed the feature/M2-6044-submit-take-now-params branch from 5901022 to 127425a Compare April 24, 2024 18:23
@sultanofcardio sultanofcardio force-pushed the feature/M2-6109-multi-informant-header branch from 1c0121c to 8e56fd6 Compare April 24, 2024 18:35
@sultanofcardio sultanofcardio force-pushed the feature/M2-6044-submit-take-now-params branch from 127425a to ace3725 Compare April 24, 2024 20:43
@sultanofcardio sultanofcardio force-pushed the feature/M2-6109-multi-informant-header branch from 8e56fd6 to e1a6d61 Compare April 24, 2024 20:47
@sultanofcardio sultanofcardio force-pushed the feature/M2-6044-submit-take-now-params branch from ace3725 to 10598bf Compare April 25, 2024 05:14
@sultanofcardio sultanofcardio force-pushed the feature/M2-6109-multi-informant-header branch from b5d378d to 3989f0a Compare April 25, 2024 05:16
@sultanofcardio sultanofcardio force-pushed the feature/M2-6044-submit-take-now-params branch from 10598bf to d1271c6 Compare April 25, 2024 18:05
@sultanofcardio sultanofcardio force-pushed the feature/M2-6109-multi-informant-header branch from 3989f0a to e7dcb20 Compare April 25, 2024 18:07
@sultanofcardio sultanofcardio force-pushed the feature/M2-6109-multi-informant-header branch from e7dcb20 to 15b2029 Compare April 29, 2024 20:42
Base automatically changed from feature/M2-6044-submit-take-now-params to dev April 30, 2024 03:35
@sultanofcardio sultanofcardio force-pushed the feature/M2-6109-multi-informant-header branch from 15b2029 to 18eca92 Compare April 30, 2024 03:38
@sultanofcardio sultanofcardio marked this pull request as ready for review April 30, 2024 03:41
Copy link
Contributor

@farmerpaul farmerpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @sultanofcardio! Works perfectly. Just left some nitpicky 🦅 comments.

src/features/TakeNow/ui/MultiInformantBadge.tsx Outdated Show resolved Hide resolved
src/features/TakeNow/ui/MultiInformantBadge.tsx Outdated Show resolved Hide resolved
@sultanofcardio sultanofcardio merged commit d7653cb into dev Apr 30, 2024
5 checks passed
@sultanofcardio sultanofcardio deleted the feature/M2-6109-multi-informant-header branch April 30, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants