Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delay take now error message by 500ms #520

Closed
wants to merge 1 commit into from
Closed

fix: Delay take now error message by 500ms #520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/features/TakeNow/ui/ValidateTakeNowParams.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,16 @@
navigate(ROUTES.appletList.path);
}

setTimeout(() =>
addErrorBanner({
children: error.error,
duration,
}),
setTimeout(
() =>
addErrorBanner({
children: error.error,
duration,
}),
500,
);
}
}, [error, addErrorBanner]);

Check warning on line 84 in src/features/TakeNow/ui/ValidateTakeNowParams.tsx

View workflow job for this annotation

GitHub Actions / ESLint

src/features/TakeNow/ui/ValidateTakeNowParams.tsx#L84 

React Hook useEffect has missing dependencies: 'logout' and 'navigate'. Either include them or remove the dependency array (react-hooks/exhaustive-deps)

if (isLoading) {
return <Loader />;
Expand Down
Loading