Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat: M2-7012) Conditional logic improvements #528

Merged
merged 21 commits into from
Aug 30, 2024
Merged

(feat: M2-7012) Conditional logic improvements #528

merged 21 commits into from
Aug 30, 2024

Conversation

moiskillnadne
Copy link
Contributor

📝 Description

🔗 Jira Ticket M2-7012

@moiskillnadne moiskillnadne added Feature New feature or request Do not merge Pull request cannot be merged for some reason In progress Work in progress labels Aug 26, 2024
@moiskillnadne moiskillnadne self-assigned this Aug 26, 2024
Viktor Riabkov added 17 commits August 26, 2024 15:31
New condition type was added to the API Types
58989c1
Update old conditional logic to a new pattern
2864707
Date conditions were added
999ee06
Validator methods for time was created
64fbbe9
Vite config. Exclude vite from optimizeDeps
39a0f66
Conditions for time was added
aecd145
TimeRange conditions was added
059c229
SliderRows conditions were added
b40834c
SingleSelectRow conditions were added
ed69e77
MultiSelectRows conditions were added
ecc2600
Small refactoring to improve readability in ConditionalLogicValidator
df50a67
Small refactoring to improve readability in ConditionalLogicValidator
ba89474
ci github job and package.json were updated
abd3bca
ConditionalLogicBuilder -> ConditionalLogicFilter rename
56fe726
ConditionalLogicValidator tests part 1
bdf0ac4
TimeRange condition tests
78ee98a
SliderRows condition tests
c678af1
@aws-amplify-us-east-1 AWS Amplify (us-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-528.d15zn9do8xbzga.amplifyapp.com

@moiskillnadne moiskillnadne added Done Feature or bug done and removed Do not merge Pull request cannot be merged for some reason In progress Work in progress labels Aug 28, 2024
BamMironov
BamMironov approved these changes Aug 29, 2024
View reviewed changes
Copy link

@BamMironov BamMironov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. However, consider the changes below

src/shared/utils/validate/time/isFirstTimeEarlier.ts Show resolved Hide resolved
src/shared/utils/validate/time/isFirstTimeLater.ts Show resolved Hide resolved
@moiskillnadne moiskillnadne merged commit 089c568 into dev Aug 30, 2024
4 checks passed
@moiskillnadne moiskillnadne deleted the feat/M2-7012-latest branch August 30, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BamMironov BamMironov BamMironov approved these changes

Assignees

@moiskillnadne moiskillnadne

Labels
Done Feature or bug done Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moiskillnadne @BamMironov