feat: action plan download updates (M2-7207) #538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-7207
This PR updates the "download" feature for Action Plan:
📸 Screenshots
N/A
🪤 Peer Testing
Preparation
On Desktop browser:
On Mobile browser:
✏️ Notes
1: Due to the way the
scale
attribute works forhtml2canvas
, the3x magnification
actually means3x of normal dpi
, and not3x of whatever is rendered on screen
. This means, if the device is already rendering the page at greater than 1x dpi (i.e. with OS-level scaling on high-dpi displays), then the downloaded images would only scale up to 3x dpi.2: Mobile device detection relies on the
isMobile
flag fromreact-device-detect
.3: Different browser have different ways of facilitating this "multiple download in a single user action" feature: Firefox will simply allow it without question; Chrome will immediately download the first image, then ask permission to download the rest of them; And Safari will ask permission to download each image.
4: There is no way to view those shared images unless they are saved somewhere. So for test, one just have to save them to the device (or on iOS, saved to a "Note").