Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Omit Report Scores with Scoring Type "Score" from the Report Summary Screen (M2-8097) #540

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

sultanofcardio
Copy link
Contributor

@sultanofcardio sultanofcardio commented Oct 23, 2024

📝 Description

🔗 Jira Ticket M2-8097

This PR updates the Report Summary screen to omit report scores configured with scoring type score. These are scores that are linked to a subscale and are currently not supported as part of the report summary screen.

📸 Screenshots

N/A

🪤 Peer Testing

Note

This PR depends on ChildMindInstitute/mindlogger-admin#1935 in order to configure the activity from the admin app

In the admin app

  1. Create an activity with a subscale containing a lookup table and an activity item (in its "Elements within Subscale" list)
  2. Create a report score and set the score type to "Score"
  3. Select the subscale from the dropdown list
  4. Create another report score and set the score type to "Raw Score"
  5. Save the activity

In the web app

  1. Complete the activity you created above
  2. Confirm that the report summary screen does not include the report score with score type set to "Score"

✏️ Notes

N/A

@sultanofcardio sultanofcardio self-assigned this Oct 23, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-540.d15zn9do8xbzga.amplifyapp.com

@sultanofcardio sultanofcardio marked this pull request as ready for review October 23, 2024 21:16
Copy link
Contributor

@farmerpaul farmerpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sultanofcardio sultanofcardio merged commit de73340 into dev Oct 25, 2024
3 checks passed
@sultanofcardio sultanofcardio deleted the feature/M2-8097-omit-subscale-report-score branch October 25, 2024 16:41
@sultanofcardio sultanofcardio restored the feature/M2-8097-omit-subscale-report-score branch October 25, 2024 16:42
@sultanofcardio sultanofcardio deleted the feature/M2-8097-omit-subscale-report-score branch October 25, 2024 16:43
@sultanofcardio
Copy link
Contributor Author

I accidentally merged this PR before QA testing, so I opened a cosmetic PR to get access to an amplify URL: https://pr-545.d15zn9do8xbzga.amplifyapp.com

Please use this URL to perform QA testing and any fixes will be applied to #545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants