-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: paragraph ItemResponseType for phrase builder response options WEB (M2-7762) #542
feature: paragraph ItemResponseType for phrase builder response options WEB (M2-7762) #542
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AlejandroCoronadoN, I found that one of the bullets in AC wasn't satisfied:
- An action plan configured with a phrase containing Paragraph Text item types will display the paragraph text, including line breaks / new lines
When I provided a paragraph of text with newlines in it, the newlines were removed in the Action Plan:
Paragraph input | Action Plan |
---|---|
…esa cross the text
Hello @farmerpaul . Here are more details about my solution:
Following up with my comments on slack, I think there is another approach that involves rendering conditional on the fieldDisplayMode value. For this implementation I will need to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AlejandroCoronadoN, thanks for making that change, it's almost there! I just noticed a couple ways the code could be made a bit clearer/simpler, and also wanted to draw your attention to a detail about consecutive line breaks.
Also, thank you for introducing me to flatMap()
! I can't believe I've never really encountered that before… 🙈🙈🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for making those changes! Just made one very minor type suggestion, and identified a rogue eslint-disable
line that I wasn't sure was intentional. Anyway, PR is ready for QA 🙂 🙌🏻
📝 Description
As an Admin, I want to choose the paragraph item type as a response phrase field so that I can include its contents in my Action Plan. By adding paragraph option to the allowed types on validate_phrasal_templates, the backend can store Activities with PhrasalBuilder Items that contain Parragraph items as elements of the PhraseBuilder item.
🔗 Jira Ticket M2-7762
Changes include:
📸 Screenshots
🪤 Peer Testing