Fix typos #4
Merged
Fix typos #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes are wonderful, thank you! However, the public API change is slightly problematic. I'm going to merge, but I'll also add in a spelling-matched version marked deprecated just to avoid breaking clients. |
|
That makes perfect sense. I considered not including that correction, but figured it'd be easiest to leave that up to you. Thanks! |
|
Yeah no worries. Normally I do this kind of thing all the time. I just happened to know that this particular change would cause me a little heartburn so I had to do it incrementally. I really try to have a bias towards accepting PRs, and I'm so happy you took the time to do it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.