Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OptiFine's Connected Textures in 1.19.3+ #1224

Closed
wants to merge 2 commits into from

Conversation

XXMA16
Copy link

@XXMA16 XXMA16 commented Sep 16, 2023

Since 8193335 made it so that the old DefaultResourcePack mixin isn't loaded in 1.19.3+ (because of Minecraft's changes), but didn't add a replacement, CTM textures won't load properly in versions strictly higher than 1.19.2.

The fix relies on MixinExtras since the code is less clunky that way. I can remove the dependency, but I though it might also be useful in the future.

There are a few problems with using MixinExtras though: if another mod uses version 0.1.1 and initializes it in a MixinConfigPlugin, against LlamaLad's advice the game will crash if the Loader version is strictly below 0.12.0. This shouldn't happen however, since other mods that depend on MixinExtras are also expected to depend on Fabric Loader >=0.14.11.

The second commit ensures that under normal circumstances the game is able to start with any Fabric Loader >=0.8.

fixes #1218 fixes #1164 fixes #1149 fixes #1107 fixes #1089 fixes #1036 fixes #1011 fixes #980
Might fix #1220 fix #1208 fix #1203

@helixxger
Copy link

So, is there any fix now?

I am on 1.19.4 with optifabric-1.13.25, fabric-api-0.85.0+1.19.4 and OptiFine_1.19.4_HD_U_I4 and still have NO connected textures on glass

@RU-B0
Copy link

RU-B0 commented Nov 11, 2023

#1036 (comment)
I found a fix here (THE NEWEST VERSION OF FUSION CRASHES THE GAME WITH AN INDIGO TESSELLATION ERROR, MUST USE FUSION 1.0.5a)

@Chocohead Chocohead closed this in 9d0ee2e Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants