Fix OptiFine's Connected Textures in 1.19.3+ #1224
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 8193335 made it so that the old DefaultResourcePack mixin isn't loaded in 1.19.3+ (because of Minecraft's changes), but didn't add a replacement, CTM textures won't load properly in versions strictly higher than 1.19.2.
The fix relies on MixinExtras since the code is less clunky that way. I can remove the dependency, but I though it might also be useful in the future.
There are a few problems with using MixinExtras though: if another mod uses version 0.1.1 and initializes it in a MixinConfigPlugin, against LlamaLad's advice the game will crash if the Loader version is strictly below 0.12.0. This shouldn't happen however, since other mods that depend on MixinExtras are also expected to depend on Fabric Loader >=0.14.11.
The second commit ensures that under normal circumstances the game is able to start with any Fabric Loader >=0.8.
fixes #1218 fixes #1164 fixes #1149 fixes #1107 fixes #1089 fixes #1036 fixes #1011 fixes #980
Might fix #1220 fix #1208 fix #1203