Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy support for zoxide #89

Merged
merged 4 commits into from
Jul 14, 2024
Merged

Legacy support for zoxide #89

merged 4 commits into from
Jul 14, 2024

Conversation

korneltlaczala
Copy link
Contributor

Implementing changes discussed in #87

TakenMC
TakenMC suggested changes Jun 29, 2024
View reviewed changes
Copy link
Contributor

@TakenMC TakenMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zoxide init passes other options to set-alias

Set-Alias -Name z -Value __zoxide_z -Option AllScope -Scope Global -Force
Set-Alias -Name zi -Value __zoxide_zi -Option AllScope -Scope Global -Force

TakenMC
TakenMC suggested changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@TakenMC TakenMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The aliases should probably be set after zoxide init in the if block
so the aliases don't appear unless zoxide is present

@ChrisTitusTech ChrisTitusTech merged commit 487142b into ChrisTitusTech:main Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TakenMC TakenMC TakenMC requested changes

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@korneltlaczala @ChrisTitusTech @TakenMC