Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API 7] SubCategories #68

Merged
merged 6 commits into from
Nov 18, 2024
Merged

[API 7] SubCategories #68

merged 6 commits into from
Nov 18, 2024

Conversation

Pjiesco
Copy link
Collaborator

@Pjiesco Pjiesco commented Oct 9, 2023

Closes #57

@Pjiesco Pjiesco added this to the 9.0.0 milestone Oct 9, 2023
@Pjiesco Pjiesco requested a review from ChristopheCVB October 9, 2023 10:34
@Pjiesco Pjiesco linked an issue Oct 9, 2023 that may be closed by this pull request
[API 7] SubCategory #57
Open
ChristopheCVB

This comment was marked as outdated.

Sign in to view

ChristopheCVB
ChristopheCVB requested changes Nov 20, 2023
View reviewed changes
Copy link
Owner

@ChristopheCVB ChristopheCVB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add unit tests

@Pjiesco
Copy link
Collaborator Author

Pjiesco commented Nov 27, 2023

I may be stupid, but where do we have tests for this?

@ChristopheCVB Volta.net
Copy link
Owner

We don't, we need to add them

@ChristopheCVB ChristopheCVB merged commit bd3073a into develop Nov 18, 2024
1 check passed
@ChristopheCVB ChristopheCVB deleted the api7/subcategory branch November 18, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopheCVB ChristopheCVB ChristopheCVB requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[API 7] SubCategory
2 participants
@Pjiesco @ChristopheCVB