Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio fixed #744

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Audio fixed #744

merged 2 commits into from
Aug 10, 2024

Conversation

hars-21
Copy link
Contributor

@hars-21 hars-21 commented Aug 9, 2024

PR Description 📜

Index page sound fixed. It will now request access before autoplaying music.
Without permission it wasn't working as chrome and many other browser restricts autoplay without interaction.

Fixes #731


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for review.

## Add your screenshots(Optional) 📸

Screen Shot 2024-08-09 at 10 11 58 PM
Screen Shot 2024-08-09 at 10 12 05 PM



Thank you soo much for contributing to our repository 💗

@ayush-t02
Copy link
Collaborator

resolve conflicts

@hars-21
Copy link
Contributor Author

hars-21 commented Aug 9, 2024

@ayush-t02 Resolved!

@ayush-t02 ayush-t02 merged commit 5d67c4d into ChromeGaming:main Aug 10, 2024
@hars-21 hars-21 deleted the sound branch August 17, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Music should be on by default
2 participants