Skip to content

Commit

Permalink
fix: made orb import manifest optional (#129)
Browse files Browse the repository at this point in the history
* fix: made orb import manifest optional

* test: fixed manifest tests

Co-authored-by: Kyle T <[email protected]>
  • Loading branch information
Jaryt and KyleTryon authored Sep 1, 2022
1 parent d00207f commit 477755b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/lib/Orb/exports/OrbImport.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ export class OrbImport implements Generable {
alias: string,
namespace: string,
orb: string,
manifest: OrbImportManifest,
version: string,
description?: string,
manifest?: OrbImportManifest,
display?: OrbDisplayMeta,
) {
this.alias = alias;
Expand Down
6 changes: 4 additions & 2 deletions tests/Orb.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,18 @@ describe('Use an OrbImport within a config', () => {
orbName,
orbNamespace,
orbName,
manifest,
orbVersion,
undefined,
manifest,
);

const exampleOrb2 = new CircleCI.orb.OrbImport(
'my-orb-aliased',
orbNamespace,
orbName,
manifest,
'1.1.1',
undefined,
manifest,
);

it('Should match expected shape', () => {
Expand Down

0 comments on commit 477755b

Please sign in to comment.