Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gsoc): layout mode fix #184

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Conversation

Arnabdaz
Copy link
Member

Fixes Layout mode loading error & layoutEditor panel

Describe the changes you have made in this PR -

  • fix layout mode crashing simualtor
  • fix layout mode layout view of circuit not loading
  • fix layout panel methods
  • remove jQuery , jQuery ui & DOM manipulation

Screenshots of the changes (If any) -

N/A

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@commit-lint
Copy link

commit-lint bot commented Aug 26, 2023

Features

  • gsoc: fix layoutmodule remove dom manipulation and fix logical errors (cd958b6)
  • gsoc: fix accordion error stopping from subcircuit loading (eab502f)

Contributors

Arnabdaz

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@netlify
Copy link

netlify bot commented Aug 26, 2023

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit eab502f
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/64ea23b60df09c000886c42a
😎 Deploy Preview https://deploy-preview-184--circuitverse.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Arnabdaz Arnabdaz changed the title Layout mode fix feat(gsoc): Layout mode fix Aug 26, 2023
@Arnabdaz Arnabdaz changed the title feat(gsoc): Layout mode fix feat(gsoc): layout mode fix Aug 26, 2023
@devartstar devartstar merged commit a518a9a into CircuitVerse:main Sep 5, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants