Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the Help Links of all the components #206

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Updating the Help Links of all the components #206

merged 6 commits into from
Jan 3, 2024

Conversation

aryanndwi123
Copy link
Contributor

@aryanndwi123 aryanndwi123 commented Dec 15, 2023

Fixes #206

Describe the changes you have made in this PR -

Updated all the Help Links in the required files (except the ones in which there is no docs regarding that page)

Screenshots of the changes (If any) -

https://circuitverse.netlify.app/simulatorvue

When we click on the help button of any component then it redirect us to the PageNotFound Page (Because the links were not updated)
0

PageNotFound
1

But after changing the links to the correct ones it works !
2

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit 360afcd
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/659577162509210008204f13
😎 Deploy Preview https://deploy-preview-206--circuitverse.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aryanndwi123 aryanndwi123 changed the title Test1 Updating the Help Links of all the components Dec 15, 2023
@aryanndwi123
Copy link
Contributor Author

Hi @Prerna-0202 @Arnabdaz ,
Can you please review my PR and tell me any changes if needed.

Copy link
Member

@Prerna-0202 Prerna-0202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the link in Stepper.js, Splitter.js and Demultiplexer.js also.

@aryanndwi123
Copy link
Contributor Author

Please change the link in Stepper.js, Splitter.js and Demultiplexer.js also.

Yes @Prerna-0202 , I made those changes!

Copy link
Member

@Prerna-0202 Prerna-0202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🎉

Copy link
Member

@Arnabdaz Arnabdaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arnabdaz Arnabdaz linked an issue Jan 3, 2024 that may be closed by this pull request
@Arnabdaz Arnabdaz merged commit a7954c0 into CircuitVerse:main Jan 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the helplink for Image Annotation
3 participants