ISICO-14427: Enable locking using Dynomite #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
January 17, 2023 15:53
redis-persistence layer.
ConnectionPoolConfigurationImpl.
sarmuru2
approved these changes
Jan 31, 2023
| ConnectionPoolMonitor cpMonitor = new DynoCPMonitor(appName); | ||
|
|
||
| DynoJedisUtils.updateConnectionPoolConfig( | ||
| cpConfig, hostSupplier, tokenMapSupplier, eurekaClient, clusterName); |
There was a problem hiding this comment.
from where the hostSupplier is configured?
There was a problem hiding this comment.
hostSupplier is initialized in line 81, i.e
HostSupplier hostSupplier = () -> Collections.singletonList(host);
There was a problem hiding this comment.
what will happen to hostsupplier when we have more than one host configured in the RedisProperties file?
sarmuru2
reviewed
Feb 2, 2023
There was a problem hiding this comment.
there is a possibility of locking the workflowId which is already locked on restart.if the conductor is shutdown with the removing the lock on workflowId, then on restart there is a chance to lock the locked workflowId on retrying the workflow. please handle this scenario
added 6 commits
February 8, 2023 18:46
to avoid duplicates.
availabilityZone to null. So that there is no localRack affinity and request get distributed.
replication latency.
added 21 commits
March 5, 2023 17:56
release 3.13.3. Changes done in PR - Netflix#3351
LoopOverTasks was empty setting 'iteration' to 1 is not correct.
map. serialLoop1_0__.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Netflix#3450
Solution:
Since Dynomite is the default persistence and queuing mechanism in Conductor, there should be an option to use Dynomite for locking as well.
Approach:
Created dyno-lock sub-project.
Default VotingHostsSelector implementation (VotingHostsFromTokenRange) considers all hosts. This will not work when hosts are used for replication as writing the lock in one node gets replicated in other nodes as well. So we need to to override this.