Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dependency-review.yml #34

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

joeyyy09
Copy link

@joeyyy09 joeyyy09 commented Apr 10, 2024

This change addresses the issue reported in Issue #33.

Changes Made

  • Added a new GitHub Actions workflow file (dependency-review.yml) to the .github/workflows directory.
  • Configured the workflow to run the Dependency Review Action on every pull request.
  • Configured permissions required by the action.
  • Specified job to run on the ubuntu-latest environment.
  • Configured the Dependency Review Action to:
    • Post a summary comment in the pull request.
    • Fail the CI if vulnerabilities with a severity of "high" are found.
    • Specify allowed licenses.
    • Specify which dependency scopes should cause the CI to fail if vulnerabilities are found.
    • Allow specific licenses for certain dependencies.

Introduce the Dependency Review GitHub Action to CI 

Signed-off-by: Harshith Mente <[email protected]>
joeyyy09 and others added 2 commits April 10, 2024 16:11
Co-authored-by: Jamie Slome <[email protected]>
Signed-off-by: Harshith Mente <[email protected]>
Co-authored-by: Jamie Slome <[email protected]>
Signed-off-by: Harshith Mente <[email protected]>
@magner669
Copy link

Would you be willing to take the issue this is referring to? I think if you commment on it I can assign it to you.

@joeyyy09
Copy link
Author

Yeah, can you walk me through what else I've got to do?

@magner669
Copy link

@joeyyy09 Please click #33 and write comment for starters.
This PR is now approved but can't be merged becuse the CodeQL check hasn't completed yet. @JamieSlome any clue?

@joeyyy09
Copy link
Author

Yeah, the CodeQL check is still waiting for status, anything to be done from my end?

@magner669 magner669 self-requested a review April 10, 2024 19:02
@magner669
Copy link

Some of the worflows require a maintainer to run., which is surprising to me and might be a valuable clue.

I allowed some of the m to run, however it didn't clear up the CodeQl check which is still "Expected".

Screenshot_20240410_200521_Brave

https://github.com/Citi/gradle-helm-plugin/actions/runs/8629901325

@joeyyy09
Copy link
Author

Hey, I've been trying to find out why the CodeQl check is still in the waiting stage, I think this is might help. Idts it has anything to do with the code but something to do with the github actions itself.
https://github.com/orgs/community/discussions/26698

@JamieSlome
Copy link
Member

I believe the CodeQL check runs periodically instead of on the pull request event.

I will open a PR to implement the CodeQL workflow 💪

@JamieSlome
Copy link
Member

@magner669 - I've removed the CodeQL status check requirement. We can address the CodeQL runner in #36.

@JamieSlome JamieSlome merged commit 2f767a8 into Citi:master Apr 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants