Give the README.md a lick of paint 🎨
#39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieSlome
commented
Apr 11, 2024
helm-plugin/src/test/kotlin/com/citi/gradle/plugins/helm/PluginVersionSynchronization.kt
Show resolved
Hide resolved
|
Please provide test evidence that we can build docs. |
Signed-off-by: Jamie Slome <[email protected]>
Signed-off-by: Jamie Slome <[email protected]>
Signed-off-by: Jamie Slome <[email protected]>
Signed-off-by: Arkadiusz Gasiński <[email protected]> Signed-off-by: Jamie Slome <[email protected]>
Signed-off-by: Jamie Slome <[email protected]>
JamieSlome
force-pushed
the
README-improvements
branch
from
cf85981
to
4fd8d2a
Compare
|
@magner669 - updated the unit test 👍 Ready to merge if you are happy ❤️ |
I think this won't affect the documentation because the asciidocs gtadle task looks at adocs in the docs diretory only https://github.com/Citi/gradle-helm-plugin/blob/master/build.gradle.kts#L169 |
magner669
requested changes
Apr 11, 2024
Signed-off-by: Jamie Slome <[email protected]>
Signed-off-by: Jamie Slome <[email protected]>
|
@magner669 - updated the file references as mentioned - apologies for the misunderstanding on my end! ❤️ |
magner669
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38