Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CL-4182: Use first language with text for slug #6274

Merged
merged 7 commits into from
Nov 2, 2023
Merged

CL-4182: Use first language with text for slug #6274

merged 7 commits into from
Nov 2, 2023

Conversation

EdwinKato
Copy link
Contributor

Changelog

Fixed

  • Smart group creation issue when en locale is not filled in

@cl-dev-bot
Copy link
Collaborator

cl-dev-bot commented Oct 31, 2023 •
edited
Loading

Messages
📖 Changelog provided 🎉
📖 Jira issue: CL-4182
📖

Run the e2e tests
📖 Check translation progress

Generated by 🚫 dangerJS against 66a12d3

@EdwinKato EdwinKato requested a review from jamesspeake October 31, 2023 05:54
jamesspeake
jamesspeake approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@jamesspeake jamesspeake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good apart from a couple of minor comments. Assume there are no changes needed on the front-end? ie there is already validation that the title_multiloc must have at least one value

back/app/models/group.rb Outdated Show resolved Hide resolved
back/spec/models/group_spec.rb Outdated Show resolved Hide resolved
@EdwinKato
Copy link
Contributor Author

All good apart from a couple of minor comments. Assume there are no changes needed on the front-end? ie there is already validation that the title_multiloc must have at least one value

Yes, all good on the frontend

@EdwinKato EdwinKato merged commit d3491f4 into master Nov 2, 2023
17 checks passed
@EdwinKato EdwinKato deleted the CL-4182-allow-slug-in-any-langauge branch November 2, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesspeake jamesspeake jamesspeake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdwinKato @cl-dev-bot @jamesspeake