Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cl 4258 empty spacing above vote button #6423

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

brentguf
Copy link
Contributor

Changelog

Fixed

  • Don't render unnecessary padding (empty spacing) above vote button

Before:
Screenshot 2023-11-20 at 09 05 37

After:
Screenshot 2023-11-20 at 09 05 01

@@ -250,64 +231,60 @@ const ReactionControl = ({
return;
};

if (idea && showReactionControl) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted both. idea is already checked higher in the file, showReactionControl is moved to the parent.

Copy link
Contributor

@amanda-anderson amanda-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@brentguf brentguf merged commit 5d5f9e4 into master Nov 20, 2023
1 check passed
@brentguf brentguf deleted the CL-4258-empty-spacing-above-vote-button branch November 20, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants