TAN-1184 - Allow method switching between all methods

[jamesspeake]

Backend changes

We now want to allow switching participation methods on a phase for all methods including native_survey. To do this I have had to change a few small things:

• Ensure that survey results are returning only survey results and not all ideas
• Ensure that 'everyone' permission gets changed if switching from native_survey
• Remove validation preventing changing to and from native_survey

There will be a warning message on the frontend when you switch to say that inputs you have already gathered may be hidden and we have discussed and are happy with the project.ideas_count potentially including hidden ideas in the edge case that a phase is changed between ideation and native_surveys when there are already inputs - this can already happen when changing phases to other methods from ideation anyway.

Any other thoughts on impacts we might have missed?

Changelog

Changed

• TAN-1184 - Allow phases to be switched between all different methods with a warning

[notion-workspace]

Enable switching from/to surveys from other participation methods

[cl-dev-bot]

	Warnings
⚠️	The PR title contains no Jira issue key (case-sensitive)
⚠️	The branch name contains no Jira issue key (case-sensitive)

	Messages
📖	Changelog provided 🎉
📖	Run the e2e tests
📖	Check translation progress

Generated by 🚫 dangerJS against 8c67303

[sebastienhoorens]

I'm surprised this is all it takes to support this 👍

I can't think of anything else we need to watch out for. I was thinking about the custom forms, but since we no longer have continuous project, I don't think it will be an issue. Did you also test out scenarios around changing the phases associated with inputs and changing the timeline?

An example I'm also thinking of is the analysis engine. If we create an analysis for e.g. a survey project and then change the participation method to ideation, will the analysis still work? I suspect we could get issues, but the analysis may no longer be reachable anyway (except by sharing a link).

However, I suspect we will have several reported #product-issues around confusion for the ideas counts.

I'm starting to think we should just accept that native survey responses and ideas are different things and make that explicit in our code (out of scope).