Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "PNE-816: Make the project search endpoint to use the teams version one" #976

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Revert "PNE-816: Make the project search endpoint to use the teams version one" #976

merged 7 commits into from
Nov 15, 2024

Conversation

pacdaemon
Copy link
Contributor

Reverts #974

@pacdaemon pacdaemon requested a review from a team as a code owner November 15, 2024 15:58
robbtraister
robbtraister reviewed Nov 15, 2024
View reviewed changes
src/citrine/__version__.py Outdated
@@ -1 +1 @@
__version__ = "3.11.1"
__version__ = "3.11.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to go to .3, since .2 is the current

@kroenlein kroenlein marked this pull request as draft November 15, 2024 16:19
@pacdaemon pacdaemon marked this pull request as ready for review November 15, 2024 16:21
@pacdaemon pacdaemon marked this pull request as draft November 15, 2024 16:22
robbtraister
robbtraister previously approved these changes Nov 15, 2024
View reviewed changes
robbtraister
robbtraister reviewed Nov 15, 2024
View reviewed changes
src/citrine/__version__.py Outdated
@@ -1 +1 @@
__version__ = "3.11.2"
__version__ = "3.11.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this now needs to be .4 because of #977

@andyczerwonka
Copy link
Contributor

andyczerwonka commented Nov 15, 2024 •
edited
Loading

As per the slack conversation, this PR is now moot because #977 solves the issue.

@andyczerwonka andyczerwonka deleted the revert-974-bugfix/PNE-816 branch November 15, 2024 16:41
@pacdaemon pacdaemon restored the revert-974-bugfix/PNE-816 branch November 15, 2024 17:04
@pacdaemon pacdaemon reopened this Nov 15, 2024
@pacdaemon pacdaemon marked this pull request as ready for review November 15, 2024 17:09
robbtraister
robbtraister previously approved these changes Nov 15, 2024
View reviewed changes
@pacdaemon pacdaemon merged commit d0cce4a into main Nov 15, 2024
16 checks passed
@pacdaemon pacdaemon deleted the revert-974-bugfix/PNE-816 branch November 15, 2024 17:13
robbtraister added a commit that referenced this pull request Nov 15, 2024
@robbtraister
Revert "Merge pull request #976 from CitrineInformatics/revert-974-bu…
b627407 
…gfix/PNE-816"

This reverts commit d0cce4a, reversing
changes made to 331afee.
@robbtraister robbtraister mentioned this pull request Nov 15, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamie-heller jamie-heller jamie-heller approved these changes

@andyczerwonka andyczerwonka andyczerwonka approved these changes

@robbtraister robbtraister robbtraister left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pacdaemon @andyczerwonka @robbtraister @jamie-heller