Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8945: disable email sending. #128

Merged
merged 4 commits into from
Sep 8, 2023
Merged

UHF-8945: disable email sending. #128

merged 4 commits into from
Sep 8, 2023

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Sep 7, 2023

Set up site normally

Reproduce error:

  • make shell, run drush cron
    • At some point you should see an error about email sending
  • Run drush cron again.
    • You should see the same error again

Fix:

  • composer require drupal/helfi_api_base:dev-UHF-8945_disable_email
  • Run drush cr
  • Run drush cron
    • The error is not shown anymore

…mail every time which floods sentry with hundreds of error messages daily.('reply-to not set' -error)
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Merging #128 (f48689b) into main (1da31a4) will increase coverage by 0.35%.
Report is 12 commits behind head on main.
The diff coverage is 75.86%.

❗ Current head f48689b differs from pull request most recent head d142c9e. Consider uploading reports for the commit d142c9e to get more accurate results

@@             Coverage Diff              @@
##               main     #128      +/-   ##
============================================
+ Coverage     64.08%   64.43%   +0.35%     
- Complexity      466      474       +8     
============================================
  Files            65       66       +1     
  Lines          1637     1659      +22     
============================================
+ Hits           1049     1069      +20     
- Misses          588      590       +2     
Files Changed Coverage Δ
src/Commands/ApiAccountCommands.php 0.00% <0.00%> (ø)
src/Commands/PubSubCommands.php 100.00% <ø> (ø)
src/Azure/PubSub/SettingsFactory.php 100.00% <100.00%> (ø)
src/Vault/Json.php 100.00% <100.00%> (ø)
src/Vault/VaultManagerFactory.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@juho-lehmonen juho-lehmonen self-requested a review September 7, 2023 10:41
helfi_api_base.module Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants