Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure PubSub message is a string #135

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Make sure PubSub message is a string #135

merged 1 commit into from
Sep 28, 2023

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Sep 28, 2023

No description provided.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #135 (3a6c45a) into main (fab6bca) will increase coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head 3a6c45a differs from pull request most recent head cfd1bea. Consider uploading reports for the commit cfd1bea to get more accurate results

@@             Coverage Diff              @@
##               main     #135      +/-   ##
============================================
+ Coverage     65.79%   65.96%   +0.17%     
  Complexity      505      505              
============================================
  Files            69       69              
  Lines          1760     1760              
============================================
+ Hits           1158     1161       +3     
+ Misses          602      599       -3
Files Coverage Δ
src/Azure/PubSub/PubSubManager.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

khalima
khalima approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix the issue. 👍 🚀

@tuutti tuutti merged commit d304750 into main Sep 28, 2023
4 checks passed
@tuutti tuutti deleted the UHF-X-make-sure-pubsub-message-is-string branch September 28, 2023 05:34
This was referenced Sep 28, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuutti @codecov-commenter @khalima