-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-9034: Proper internal address support #136
Conversation
Codecov Report
@@ Coverage Diff @@
## main #136 +/- ##
============================================
+ Coverage 65.79% 66.10% +0.30%
- Complexity 505 510 +5
============================================
Files 69 70 +1
Lines 1760 1767 +7
============================================
+ Hits 1158 1168 +10
+ Misses 602 599 -3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
helfi_api_base PR
Looks good 💪 Had a look at the fixtures file and also did a quick search if any of the projects used the removed public methods Environment::getDomain
or Environment::getProtocol
(found nothing).
No description provided.