Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9034: Proper internal address support #136

Merged
merged 6 commits into from
Oct 5, 2023
Merged

UHF-9034: Proper internal address support #136

merged 6 commits into from
Oct 5, 2023

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Oct 3, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

Merging #136 (e796023) into main (d304750) will increase coverage by 0.30%.
The diff coverage is 100.00%.

❗ Current head e796023 differs from pull request most recent head 150ee01. Consider uploading reports for the commit 150ee01 to get more accurate results

@@             Coverage Diff              @@
##               main     #136      +/-   ##
============================================
+ Coverage     65.79%   66.10%   +0.30%     
- Complexity      505      510       +5     
============================================
  Files            69       70       +1     
  Lines          1760     1767       +7     
============================================
+ Hits           1158     1168      +10     
+ Misses          602      599       -3     
Files Coverage Δ
src/Cache/CacheTagInvalidator.php 100.00% <100.00%> (ø)
src/Environment/Address.php 100.00% <100.00%> (ø)
src/Environment/Environment.php 100.00% <100.00%> (ø)
src/Environment/EnvironmentResolver.php 97.40% <100.00%> (ø)
.../EventSubscriber/CacheTagInvalidatorSubscriber.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@hyrsky hyrsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helfi_api_base PR
Looks good 💪 Had a look at the fixtures file and also did a quick search if any of the projects used the removed public methods Environment::getDomain or Environment::getProtocol (found nothing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants