Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10713: Remove VersionChecker service #193

Merged
merged 3 commits into from
Dec 17, 2024
Merged

UHF-10713: Remove VersionChecker service #193

merged 3 commits into from
Dec 17, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Dec 16, 2024

UHF-10713

What was done

  • Wrapper for composer outdated command in VersionChecker service
  • Print composer outdated as markdown in update-config workflow.
  • Test dependabot for updating direct dependencies.
  • Allow running helfi:tools:update-platform from any branch.

How to install

`composer require drupal/helfi_drupal_tools:dev-UHF-10713`
`composer require drupal/helfi_api_base:dev-UHF-10713`
`composer require drupal/hdbt_admin:dev-UHF-10713`

How to test

  • Check debug pagee
  • Run drush helfi:tools:check-composer-versions $PWD/composer.lock
  • Code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Other PRs

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.63%. Comparing base (096a75d) to head (fa87b6a).

Files with missing lines Patch % Lines
src/Plugin/rest/resource/PackageVersion.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #193      +/-   ##
============================================
- Coverage     89.07%   88.63%   -0.45%     
+ Complexity      527      504      -23     
============================================
  Files            79       76       -3     
  Lines          2106     2033      -73     
============================================
- Hits           1876     1802      -74     
- Misses          230      231       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyrsky hyrsky marked this pull request as ready for review December 17, 2024 05:52
src/Exception/VersionCheckException.php Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 17, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants