HAI-1841 Add better error messages for failed attachment uploads (#361)

Added specific error messages for failed attachment uploads in cable report application form. One for bad request (when there is something wrong with the file) and one for error caused by technical reason.
City-of-Helsinki · Aug 24, 2023 · 4821d58 · 4821d58
1 parent cb82fba
commit 4821d58
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 6 deletions.
diff --git a/src/domain/johtoselvitys/JohtoselvitysContainer.tsx b/src/domain/johtoselvitys/JohtoselvitysContainer.tsx
@@ -208,11 +208,13 @@ const JohtoselvitysContainer: React.FC<React.PropsWithChildren<Props>> = ({
     },
     onError(error: AxiosError, { file }) {
       setAttachmentUploadErrors((errors) => {
-        // TODO: Should show different error texts for different kinds of errors,
-        // once those texts have been defined
+        const errorMessage =
+          error.response?.status === 400
+            ? t('form:errors:fileLoadBadFileError', { fileName: file.name })
+            : t('form:errors:fileLoadTechnicalError', { fileName: file.name });
         return errors.concat(
           <Box as="p" key={file.name} mb="var(--spacing-s)">
-            {file.name}: {t('common:error')}
+            {errorMessage}
           </Box>,
         );
       });

diff --git a/src/locales/en.json b/src/locales/en.json
@@ -76,7 +76,9 @@
     "errors": {
       "areaRequired": "At least one area is required",
       "fileLoadError": "Error in loading file",
-      "selfIntersectingArea": "The area borders cannot intersect with each other"
+      "selfIntersectingArea": "The area borders cannot intersect with each other",
+      "fileLoadTechnicalError": "Uploading the file ({{fileName}}) failed. Please try again later.",
+      "fileLoadBadFileError": "There is a problem with the file ({{fileName}}). Please check that the file format is correct and the file size does not exceed 100 MB."
     },
     "headers": {
       "perustiedot": "Basic information",

diff --git a/src/locales/fi.json b/src/locales/fi.json
@@ -80,7 +80,9 @@
     "errors": {
       "areaRequired": "Vähintään yksi alue vaaditaan",
       "fileLoadError": "Tiedoston latauksessa tapahtui virhe",
-      "selfIntersectingArea": "Alueen reunat eivät saa leikata toisiaan"
+      "selfIntersectingArea": "Alueen reunat eivät saa leikata toisiaan",
+      "fileLoadTechnicalError": "Tiedoston ({{fileName}}) lataus epäonnistui, yritä hetken päästä uudelleen.",
+      "fileLoadBadFileError": "Tiedosto ({{fileName}}) on viallinen. Tarkistathan, että tiedostomuoto on oikea eikä sen koko ylitä sallittua maksimikokoa."
     },
     "headers": {
       "perustiedot": "Perustiedot",

diff --git a/src/locales/sv.json b/src/locales/sv.json
@@ -76,7 +76,9 @@
     "errors": {
       "areaRequired": "Det krävs minst ett område",
       "fileLoadError": "Fel i laddning av fil",
-      "selfIntersectingArea": "Områdets kanter får inte skära varandra"
+      "selfIntersectingArea": "Områdets kanter får inte skära varandra",
+      "fileLoadTechnicalError": "Laddning av filen ({{fileName}}) misslyckades, försök igen om en stund.",
+      "fileLoadBadFileError": "Filen ({{fileName}}) är felaktig. Kontrollera att filen har rätt format och att den inte är större än 100 MB."
     },
     "headers": {
       "perustiedot": "Basdata",