Skip to content

Commit

Permalink
HAI-1814 Fix sending multiple application delete requests
Browse files Browse the repository at this point in the history
Fixed a problem where user could press confirm button in application cancel dialog
many times in a row, which would send multiple delete requests to backend.
Fixed this by putting the confirm button in loading state when clicking it first time.
  • Loading branch information
markohaarni committed Oct 4, 2023
1 parent 8e9a64d commit aa5fc00
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 0 deletions.
25 changes: 25 additions & 0 deletions src/domain/application/applicationView/ApplicationView.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { render, screen } from '../../../testUtils/render';
import ApplicationViewContainer from './ApplicationViewContainer';
import { waitForLoadingToFinish } from '../../../testUtils/helperFunctions';
import { server } from '../../mocks/test-server';
import * as applicationApi from '../utils';

test('Correct information about application should be displayed', async () => {
render(<ApplicationViewContainer id={4} />);
Expand Down Expand Up @@ -90,3 +91,27 @@ test('Should not be able to cancel application if it has moved to handling in Al

expect(screen.queryByRole('button', { name: 'Peru hakemus' })).not.toBeInTheDocument();
});

test('Should not send multiple requests if clicking application cancel confirm button many times', async () => {
server.use(
rest.delete('/api/hakemukset/:id', async (req, res, ctx) => {
return res(ctx.delay(200), ctx.status(200));
}),
);

const cancelApplication = jest.spyOn(applicationApi, 'cancelApplication');
const { user } = render(<ApplicationViewContainer id={1} />);

await waitForLoadingToFinish();

await user.click(screen.getByRole('button', { name: 'Peru hakemus' }));
const confirmCancelButton = screen.getByRole('button', { name: 'Vahvista' });
await user.click(confirmCancelButton);
await user.click(confirmCancelButton);
await user.click(confirmCancelButton);
await screen.findByText('Hakemus peruttiin onnistuneesti');

expect(cancelApplication).toHaveBeenCalledTimes(1);

cancelApplication.mockRestore();
});
1 change: 1 addition & 0 deletions src/domain/application/components/ApplicationCancel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ export const ApplicationCancel: React.FC<Props> = ({
mainBtnLabel={t('common:confirmationDialog:confirmButton')}
variant="danger"
errorMsg={errorMessage}
isLoading={applicationCancelMutation.isLoading}
/>

<Button
Expand Down

0 comments on commit aa5fc00

Please sign in to comment.