Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAI-1814 Fix sending multiple application delete requests #383

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

markohaarni
Copy link
Contributor

Description

Fixed a problem where user could press confirm button in application cancel dialog many times in a row, which would send multiple delete requests to backend. Fixed this by putting the confirm button in loading state when clicking it first time.

Jira Issue: https://helsinkisolutionoffice.atlassian.net/browse/HAI-1814

Type of change

  • Bug fix
  • New feature
  • Other

Instructions for testing

  1. Create new cable report application, first page is enough to fill, and save it.
  2. Press Cancel application button in application page
  3. Open the Network tab in browser developer tools
  4. Try to click the Confirm button in the delete dialog as many times as you can
  5. There should only be one delete request in the Network tab

Checklist:

  • I have written new tests (if applicable)
  • I have ran the tests myself (if applicable)
  • I have made necessary changes to the documentation, link to confluence
    or other location:

Other relevant info

Please describe here if there is e.g. some requirements for this change or
other info that the tester/user needs to know.

Fixed a problem where user could press confirm button in application cancel dialog
many times in a row, which would send multiple delete requests to backend.
Fixed this by putting the confirm button in loading state when clicking it first time.
@markohaarni markohaarni merged commit 0e70262 into dev Oct 10, 2023
1 check passed
@markohaarni markohaarni deleted the HAI-1814 branch October 10, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants