Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAI-1463 Change frontend to use hanke status returned from backend #391

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

markohaarni
Copy link
Contributor

Description

Status of hanke can be either DRAFT, PUBLIC or ENDED and this information is returned from backend. Changed frontend to keep track of the backend state.

At this point this affects displaying draft state notification if hanke status is DRAFT as well as displaying
Add application button in hanke form and hanke view if hanke status is PUBLIC.

Also removed the saveType field as it's not needed anymore.

Jira Issue: https://helsinkisolutionoffice.atlassian.net/browse/HAI-1463

Type of change

  • Bug fix
  • New feature
  • Other

Instructions for testing

  1. Create new hanke and only fill first page of the form and save the hanke
  2. Go to the last page of the form and check that there is no "Tallenna ja lisää hakemuksia" button
  3. Go to "Omat hankkeet" and check that the new hanke has notification "Hanke on luonnostilassa. Alueiden haittatiedot ja muut pakolliset tiedot on täytettävä hankkeen julkaisemiseksi ja lupien lisäämiseksi."
  4. Go to hanke page of that new hanke and check that the draft notification is there too and that "Lisää hakemus" button is not visible
  5. Edit your new hanke and fill the areas page and also fill at least "Hankkeen omistaja" and their contact person and save the hanke.
  6. Now the hanke should be public and "Tallenna ja lisää hakemuksia" button should be displayed in the last page of the form as well as "Lisää hakemus" button in hanke page and the draft notifications should be gone.

Checklist:

  • I have written new tests (if applicable)
  • I have ran the tests myself (if applicable)
  • I have made necessary changes to the documentation, link to confluence
    or other location:

Other relevant info

Please describe here if there is e.g. some requirements for this change or
other info that the tester/user needs to know.

Status of hanke can be either DRAFT, PUBLIC or ENDED and this
information is returned from backend. Changed frontend to keep
track of the backend state.

At this point this affects displaying draft state notification
if hanke status is DRAFT as well as displaying
Add application button in hanke form and hanke view
if hanke status is PUBLIC.

Also removed the saveType field as it's not needed anymore.
@markohaarni markohaarni merged commit f1c0d6a into dev Oct 18, 2023
1 check passed
@markohaarni markohaarni deleted the HAI-1463 branch October 18, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants