Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAI-1881 Save hanke form in summary page #393

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

markohaarni
Copy link
Contributor

Description

Made changes to saving hanke form when clicking Save button in summary page. Now instead of taking user to hanke list after saving, user ends up in the hanke page and success notification is displayed.

Also changed the Save and quit button to do the same thing.

Jira Issue: https://helsinkisolutionoffice.atlassian.net/browse/HAI-1881

Type of change

  • Bug fix
  • New feature
  • Other

Instructions for testing

  1. Create new hanke and fill at least the first page
  2. Go to the last page of the form
  3. Click the Save ("Tallenna") button
  4. Check that you are taken to hanke page of the new hanke and that there is success notification displayed

Checklist:

  • I have written new tests (if applicable)
  • I have ran the tests myself (if applicable)
  • I have made necessary changes to the documentation, link to confluence
    or other location:

Other relevant info

Please describe here if there is e.g. some requirements for this change or
other info that the tester/user needs to know.

Status of hanke can be either DRAFT, PUBLIC or ENDED and this
information is returned from backend. Changed frontend to keep
track of the backend state.

At this point this affects displaying draft state notification
if hanke status is DRAFT as well as displaying
Add application button in hanke form and hanke view
if hanke status is PUBLIC.

Also removed the saveType field as it's not needed anymore.
Made changes to saving hanke form when clicking Save button
in summary page. Now instead of taking user to hanke list
after saving, user ends up in the hanke page and success
notification is displayed.

Also changed the Save and quit button to do the same thing.
Copy link
Contributor

@corvidian corvidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended.

Base automatically changed from HAI-1463 to dev October 18, 2023 07:29
@markohaarni markohaarni merged commit 4c66865 into dev Oct 18, 2023
1 check passed
@markohaarni markohaarni deleted the HAI-1881/save-hanke-form-in-summary-page branch October 18, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants