-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release HAI.01.6 #399
Merged
Release HAI.01.6 #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change hanke contact data model - Split sub contact name to first name and last name. - Remove address information from contacts. - sub contact phone is now mandatory. - Sub contact form should be always visible (if contact is) - You can add many sub contacts. Additional: the ticket does not mention this but ytunnusTaiHetu was changed to just ytunnus. It is visible if contact is not a person. Note: This commit does not fix / change everything that needs to be changed in yhteystieto page. For example, the styling of the page does not figma, but that task is not part of this task.
When user comes to Haitaton from invitation link, call identify endpoint with token included in the link. After identifying user, show success notification and redirect user to front page. If user is not signed in before coming to Haitaton, redirect user to login and after login, do the identifying.
* HAI-1599 Navigate to hanke list after generated hanke deletion When the only application of a genedated hanke is deleted, backend also deletes the hanke. If hanke deletion result is defined in the response object. If hanke was deleted, user is directed to hanke listing.
This information is received from another field, remove it from the enum as redundant.
…#378) Added button for each user in the list to send invitation link to that user again if that user has not been identified in Haitaton before. When the button is pressed it is disabled and it's text is changed to Kutsulinkki lähetetty until the user visits the page again.
…s not have edit rights (#379) Edit hanke link button (pen icon) is hidden in hanke list if user does not have edit rights for that hanke.
#380) Show Edit hanke button if user has EDIT permission. Show Add application button if user has EDIT_APPLICATIONS permission. Show End hanke button if user has DELETE permission. Show Cancel hanke button if user has DELETE permission.
…ns (#381) Show Edit application and Cancel application buttons if user has Kaikki oikeudet, Hankkeen ja hakemuksen muokkaus or Hakemusasiointi permission for the hanke.
…g sub-contacts in cable report application (#382) If there were validation errors when user pressed Fill with own information button, those errors remained even when they should not.
Added Helsinki logo to public folder so it can be used in backend in the invitation emails.
Haitaton backend has a limit for hanke name (100 characters). Include this limit in the frontend.
Fixed a problem where user could press confirm button in application cancel dialog many times in a row, which would send multiple delete requests to backend. Fixed this by putting the confirm button in loading state when clicking it first time.
Instead of just one joukkoliikenneindeksi show separate indexes for bus and tram.
Add description on what Haitaton is.
…rt application form (#385) When triggering form validations, field paths in the array given to react-hook-form trigger function were not in correct order, and so focus went to wrong field when there were errors. Fixed this by making sure the field paths are in correct order.
Fixed problem where form page in hanke form and cable report application form would not be scrolled to top when entering the form or changing form page. Made it so that window.scrollTo(0, 0) is called in each page change and also when changing form page.
) Status of hanke can be either DRAFT, PUBLIC or ENDED and this information is returned from backend. Changed frontend to keep track of the backend state. At this point this affects displaying draft state notification if hanke status is DRAFT as well as displaying Add application button in hanke form and hanke view if hanke status is PUBLIC. Also removed the saveType field as it's not needed anymore.
Made changes to saving hanke form when clicking Save button in summary page. Now instead of taking user to hanke list after saving, user ends up in the hanke page and success notification is displayed. Also changed the Save and quit button to do the same thing.
HAI-2057 Removed Suunnitteluvaihe field from Hanke. Also, removed tool-tip sentence from Vaihe that referenced Suunnitteluvaihe.
markohaarni
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.