Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HKISD-226: changes to showing sap values #308

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

saijaseppa
Copy link
Contributor

@saijaseppa saijaseppa commented Dec 17, 2024

Description

New with these changes:

  • in project card (ListField.ts)

    • in addition to old SAP values, new row "sap costs from current year" is added
    • Current year's sap values are fetched using new endpoint (HKISD-230: feat create endpoint for current year sap values infraohjelmointi-api#217)
    • logic behind the sap values was changed
      • Toteuma kuluva vuosi = projectTaskCosts + productionTaskCosts from current year
      • Toteuma yhteensä = projectTaskCosts + productionTaskCosts from the planning start year to end of current year
      • Sitoumukset yhteensä = projectTaskCommitments + productionTaskCommitments from the planning start year to end of current year
      • Käytetty = Toteuma yhteensä + Sitoumukset yhteensä
    • added tooltip (from HDS) for these values to explain values to user
  • in planningView's SAP values (ProjectYearSummaryTable.tsx)

    • sap values are now only current year's values in planning view

Testing

Copy link

sonarcloud bot commented Dec 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
14.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant