Mvj 234 more tests for gdpr api #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favourite does not seem like a model that needs to be kept around after user deletion
henrinie-nc
force-pushed
the
MVJ-234-gdpr-api
branch
from
90dc304 to
c8f00db
Compare
gdpr/tests/test_gdpr_views.py
Outdated
| "API_AUTHORIZATION_FIELD": "authorization.permissions.scopes", | ||
| } | ||
|
|
||
| user = user_factory(first_name="Jari", last_name="Kuningas") |
There was a problem hiding this comment.
This is a real person. I would use something like "UserFirstName" and "UserLastName"
There was a problem hiding this comment.
... unless it's required for the Suomi.fi authentication
There was a problem hiding this comment.
Not required, fair point, although it is not a real name
There was a problem hiding this comment.
I mean, that person exists in the real world, I googled it :) But not in our system.
juho-kettunen-nc
approved these changes
Nov 21, 2024
henrinie-nc
force-pushed
the
MVJ-234-gdpr-api
branch
from
e6a764f to
a7b5373
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for utils, which test actual deletion behavior.
Adds tests for views, which are partly done to document the behavior rather than actually testing - since the original package tests those already.
Adds migration to delete Favourite objects that are related to the user that is being deleted. Favourite is like the shopping cart of this app, so it doesnt need to be persisted.