Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor reservations #994

Closed
wants to merge 1 commit into from
Closed

Refactor reservations #994

wants to merge 1 commit into from

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Nov 27, 2023 •
edited by jira bot
Loading

🛠️ Changelog

  • Refactor the whole of the reservation app: reservations, recurring reservations, age groups, ability groups, reservation purposes, and reservation cancel & deny reasons

DONE:

  • Model changes for all models (could still go though together and see if all fields are required)
  • API changes for everything except reservation queries and mutations
  • Tests have been rewritten for everything except reservation queries and mutations

TODO:

  • reservation queries and mutations API and tests

🧪 Test plan

  • Automated tests

🎫 Tickets

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

90.8% 90.8% Coverage
0.0% 0.0% Duplication

@matti-lamppu matti-lamppu force-pushed the refactor-reservations branch 3 times, most recently from 9efed8a to 0e73ffd Compare December 14, 2023 13:06
@matti-lamppu matti-lamppu force-pushed the refactor-reservations branch from 08195d9 to cdba350 Compare January 2, 2024 07:36
@matti-lamppu matti-lamppu force-pushed the refactor-reservations branch 2 times, most recently from 9568f20 to 128f51c Compare January 11, 2024 09:34
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
91.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@matti-lamppu matti-lamppu force-pushed the refactor-reservations branch 2 times, most recently from b7958dc to 8d5bdc0 Compare January 31, 2024 13:16
@matti-lamppu matti-lamppu force-pushed the refactor-reservations branch from 8d5bdc0 to 0a9f2a8 Compare January 31, 2024 13:31
@matti-lamppu matti-lamppu added refactor Refactors something feature Adds a new feature labels Feb 22, 2024
@matti-lamppu matti-lamppu self-assigned this Feb 22, 2024
@matti-lamppu
Copy link
Collaborator Author

This is superseded by #1131

@matti-lamppu matti-lamppu deleted the refactor-reservations branch April 8, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matti-lamppu matti-lamppu

Labels
feature Adds a new feature refactor Refactors something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matti-lamppu