fix: text improvements & added localizations (Hl-1425 & HL-1486) (#3451)

* fix: better text for opening application for editing * fix: missing localization for handler change log added * fix: missing localization for received application status * fix: text in test updated * fix: to prev. commit: received status not used for applicant
City-of-Helsinki · Oct 28, 2024 · 6105923 · 6105923
1 parent b933b1f
commit 6105923
Show file tree

Hide file tree

Showing 8 changed files with 55 additions and 7 deletions.
diff --git a/backend/benefit/applications/tests/test_applications_api.py b/backend/benefit/applications/tests/test_applications_api.py
@@ -1391,7 +1391,7 @@ def test_application_status_change_as_handler(
         if to_status == ApplicationStatus.ADDITIONAL_INFORMATION_NEEDED:
             assert application.messages.count() == 1
             assert (
-                "Please make the corrections by 11.06.2021"
+                "Please make the corrections and send application again by 11.06.2021"
                 in application.messages.first().content
             )
             assert len(mailoutbox) == 1

diff --git a/backend/benefit/locale/en/LC_MESSAGES/django.po b/backend/benefit/locale/en/LC_MESSAGES/django.po
@@ -1399,7 +1399,7 @@ msgstr "Swedish"
 
 #, python-brace-format
 msgid ""
-"Your application has been opened for editing. Please make the corrections by "
+"Your application has been opened for editing. Please make the corrections and send application again by "
 "{additional_information_needed_by}, otherwise the application cannot be "
 "processed."
 msgstr ""

diff --git a/backend/benefit/locale/fi/LC_MESSAGES/django.po b/backend/benefit/locale/fi/LC_MESSAGES/django.po
@@ -1441,11 +1441,11 @@ msgstr "Ruotsi"
 
 #, python-brace-format
 msgid ""
-"Your application has been opened for editing. Please make the corrections by "
+"Your application has been opened for editing. Please make the corrections and send application again by "
 "{additional_information_needed_by}, otherwise the application cannot be "
 "processed."
 msgstr ""
-"Hakemuksesi on avattu muokattavaksi. Tee korjaukset viimeistään "
+"Hakemuksesi on avattu muokattavaksi. Tee korjaukset ja lähetä lomake uudelleen viimeistään "
 "{additional_information_needed_by} mennessä, muuten hakemusta ei voida "
 "käsitellä."
 

diff --git a/backend/benefit/locale/sv/LC_MESSAGES/django.po b/backend/benefit/locale/sv/LC_MESSAGES/django.po
@@ -1466,11 +1466,11 @@ msgstr "Svenska"
 
 #, python-brace-format
 msgid ""
-"Your application has been opened for editing. Please make the corrections by "
+"Your application has been opened for editing. Please make the corrections and send application again by "
 "{additional_information_needed_by}, otherwise the application cannot be "
 "processed."
 msgstr ""
-"Din ansökan har öppnats för redigering. Gör ändringarna senast "
+"Din ansökan har öppnats för redigering. Gör ändringarna och skicka ansökan igen senast "
 "{additional_information_needed_by}, annars kan ansökan inte behandlas."
 
 msgid ""

diff --git a/backend/benefit/messages/automatic_messages.py b/backend/benefit/messages/automatic_messages.py
@@ -16,7 +16,7 @@
 LOGGER = logging.getLogger(__name__)
 
 APPLICATION_REOPENED_MESSAGE = _(
-    "Your application has been opened for editing. Please make the corrections by "
+    "Your application has been opened for editing. Please make the corrections and send application again by "
     "{additional_information_needed_by}, otherwise the application cannot be processed."
 )
 

diff --git a/frontend/benefit/handler/public/locales/en/common.json b/frontend/benefit/handler/public/locales/en/common.json
@@ -740,6 +740,7 @@
         "accepted": "Hakemus on hyväksytty ja Helsinki-lisää on myönnetty aikavälille {{dateRangeStart}} – {{dateRangeEnd}}",
         "rejected": "Hakemus on hylätty. Helsinki-lisää ei myönnetä.",
         "handling": "Hakemus on käsittelyssä.",
+        "received": "Hakemus on vastaanotettu.",
         "cancelled": "Hakemus on peruttu.",
         "additional_information_needed": "Hakemus on käsittelyssä."
       },
@@ -1819,6 +1820,21 @@
       },
       "handledByAhjoAutomation": {
         "label": "Käsitelty Ahjo automaatiolla"
+      },
+      "officialCompanyStreetAddress": {
+        "label": "Katuosoite"
+      },
+      "companyName": {
+        "label": "Työantaja"
+      },
+      "officialCompanyPostcode": {
+        "label": "Postinumero"
+      },
+      "officialCompanyCity": {
+        "label": "Postitoimipaikka"
+      },
+      "companyForm": {
+        "label": "Yritysmuoto"
       }
     }
   }

diff --git a/frontend/benefit/handler/public/locales/fi/common.json b/frontend/benefit/handler/public/locales/fi/common.json
@@ -740,6 +740,7 @@
         "accepted": "Hakemus on hyväksytty ja Helsinki-lisää on myönnetty aikavälille {{dateRangeStart}} – {{dateRangeEnd}}",
         "rejected": "Hakemus on hylätty. Helsinki-lisää ei myönnetä.",
         "handling": "Hakemus on käsittelyssä.",
+        "received": "Hakemus on vastaanotettu.",
         "cancelled": "Hakemus on peruttu.",
         "additional_information_needed": "Hakemus on käsittelyssä."
       },
@@ -1818,6 +1819,21 @@
       },
       "handledByAhjoAutomation": {
         "label": "Käsitelty Ahjo automaatiolla"
+      },
+      "officialCompanyStreetAddress": {
+        "label": "Katuosoite"
+      },
+      "companyName": {
+        "label": "Työantaja"
+      },
+      "officialCompanyPostcode": {
+        "label": "Postinumero"
+      },
+      "officialCompanyCity": {
+        "label": "Postitoimipaikka"
+      },
+      "companyForm": {
+        "label": "Yritysmuoto"
       }
     }
   }

diff --git a/frontend/benefit/handler/public/locales/sv/common.json b/frontend/benefit/handler/public/locales/sv/common.json
@@ -740,6 +740,7 @@
         "accepted": "Hakemus on hyväksytty ja Helsinki-lisää on myönnetty aikavälille {{dateRangeStart}} – {{dateRangeEnd}}",
         "rejected": "Hakemus on hylätty. Helsinki-lisää ei myönnetä.",
         "handling": "Hakemus on käsittelyssä.",
+        "received": "Hakemus on vastaanotettu.",
         "cancelled": "Hakemus on peruttu.",
         "additional_information_needed": "Hakemus on käsittelyssä."
       },
@@ -1819,6 +1820,21 @@
       },
       "handledByAhjoAutomation": {
         "label": "Käsitelty Ahjo automaatiolla"
+      },
+      "officialCompanyStreetAddress": {
+        "label": "Katuosoite"
+      },
+      "companyName": {
+        "label": "Työantaja"
+      },
+      "officialCompanyPostcode": {
+        "label": "Postinumero"
+      },
+      "officialCompanyCity": {
+        "label": "Postitoimipaikka"
+      },
+      "companyForm": {
+        "label": "Yritysmuoto"
       }
     }
   }