Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add platform definitions to docker compose files #2287

Merged
merged 1 commit into from
Nov 6, 2023
Merged

feat: add platform definitions to docker compose files #2287

merged 1 commit into from
Nov 6, 2023

Conversation

arpargo
Copy link
Contributor

@arpargo arpargo commented Sep 22, 2023

To ensure that mac m1&m2 chips use amd images instead of the arm ones. This way we all should be using the same base images.

@sirtawast sirtawast changed the title feat: added platform definitions to docker compose files feat: add platform definitions to docker compose files Oct 11, 2023
@sirtawast sirtawast requested a review from rikuke October 30, 2023 11:13
rikuke
rikuke approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@rikuke rikuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this works with Apple Silicon as well.

@karisal-anders karisal-anders merged commit b414db7 into main Nov 6, 2023
7 checks passed
@karisal-anders karisal-anders deleted the docker-compose-platform branch November 6, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karisal-anders karisal-anders karisal-anders approved these changes

@rikuke rikuke rikuke approved these changes

@sirtawast sirtawast Awaiting requested review from sirtawast

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arpargo @rikuke @karisal-anders