Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only one row per application in Talpa CSV export #2289

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix: only one row per application in Talpa CSV export #2289

merged 1 commit into from
Sep 25, 2023

Conversation

rikuke
Copy link
Collaborator

@rikuke rikuke commented Sep 22, 2023

Description ✨

Talpa CSV export has multiple rows per application because it uses the same row generation logic as Ahjo export, which generates a row per application calculation row. This PR fixes the Talpa export so, that only one row per application is generated when exporting for Talpa with the prune_data_for_talpa parameter set to True.

Issues 🐛

Testing ⚗️

Create a batch with applications and mark them ready for talpa.
Visit the talpa api endpoint at /v1/applicationbatches/talpa_export, to download the CSV.

Screenshots 📸

Additional notes 🗒️

@rikuke rikuke requested review from sirtawast and mjturt September 22, 2023 11:52
@sonarqubecloud
Copy link

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

88.9% 88.9% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2289.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2289.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2289.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2289.dev.hel.ninja 😆🎉🎉🎉

@rikuke rikuke merged commit 557e823 into main Sep 25, 2023
53 checks passed
@rikuke rikuke deleted the HL-969-talparows branch September 25, 2023 09:21
@github-actions github-actions bot mentioned this pull request Sep 25, 2023
Merged
@github-actions github-actions bot mentioned this pull request Dec 8, 2023
Merged
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjturt mjturt mjturt approved these changes

@sirtawast sirtawast sirtawast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rikuke @terovirtanen @sirtawast @mjturt