Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: renew application overview step (HL-945) #2334

Merged
merged 8 commits into from
Oct 11, 2023
Merged

feat: renew application overview step (HL-945) #2334

merged 8 commits into from
Oct 11, 2023

Conversation

sirtawast
Copy link
Collaborator

Description ✨

  • Rewrite overview of application form to conform term changes
  • Extract ibantools to shared
  • Fix step 1 issue with employment start date picker not setting the correct end date
  • Still missing en/sv translations

@sirtawast sirtawast changed the title Hl 945 b feat: renew application step 5 (overview) Oct 6, 2023
@sirtawast sirtawast changed the title feat: renew application step 5 (overview) feat: renew application overview step (HL-945) Oct 6, 2023
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2334.api.dev.hel.ninja/healthz 🚀🚀🚀

@sirtawast sirtawast requested review from mjturt and rikuke October 6, 2023 07:00
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 152 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 44 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

87.5% 87.5% Coverage
0.0% 0.0% Duplication

mjturt
mjturt approved these changes Oct 6, 2023
View reviewed changes
frontend/benefit/applicant/public/locales/en/common.json
@@ -83,6 +83,7 @@
"deMinimisAidsHeading": "Below, please fill in all the de minimis aid granted to the organisation for the current and two previous tax years.",
"deMinimisAidsAdd": "Save",
"deMinimisAidsRemove": "Delete",
"deMinimisAidsYes": "TODO",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjturt No translations yet.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JanneJuhola works on those

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2334.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2334.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2334.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2334.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2334.dev.hel.ninja 😆🎉🎉🎉

@sirtawast sirtawast merged commit 196af97 into main Oct 11, 2023
59 checks passed
@sirtawast sirtawast deleted the hl-945-b branch October 11, 2023 09:43
This was referenced Oct 11, 2023
Closed
Closed
Closed
Merged
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Merged
@github-actions github-actions bot mentioned this pull request Dec 8, 2023
Merged
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjturt mjturt mjturt approved these changes

@rikuke rikuke Awaiting requested review from rikuke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirtawast @terovirtanen @mjturt