Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: application is no longer 404'd on creation and navigation to inspect it | HL-936 #2338

Merged
merged 6 commits into from
Oct 16, 2023
Merged

fix: application is no longer 404'd on creation and navigation to inspect it | HL-936 #2338

merged 6 commits into from
Oct 16, 2023

Conversation

sirtawast
Copy link
Collaborator

@sirtawast sirtawast commented Oct 12, 2023 •
edited
Loading

Description ✨

  • Fix the "isReadOnly" bug where app would show 404/error if application is submitted and then right away accessed from the index view route /
    • Remove the &isReadOnly=1 parameter as it's unnecessary and is just unclear compared to editability based on status
  • Further improve browser tests (now fill the ENTIRE form and submit it)

@sirtawast sirtawast mentioned this pull request Oct 12, 2023
Closed
@sirtawast sirtawast requested review from mjturt and rikuke October 12, 2023 15:38
@sirtawast sirtawast changed the title fix: applicant's navigation to application no longer results in crash | HL-936 fix: application is no longer 404'd when creating one and navigating to inspect it | HL-936 Oct 12, 2023
@sirtawast sirtawast changed the title fix: application is no longer 404'd when creating one and navigating to inspect it | HL-936 fix: application is no longer 404'd on creation and navigation to inspect it | HL-936 Oct 12, 2023
@sirtawast
fix: get rid of isReadOnly flag
d6c9e0f 
the data already exists in prop so no need to make router checks
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://tet-pr2338.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2338.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2338.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://kesaseteli-handler-pr2338.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2338.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2338.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-handler-pr2338.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe applicant result is failed for https://helsinkilisa-ui-pr2338.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

ADMIN branch is deployed to platta: https://tet-admin-ui-pr2338.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://tet-youth-ui-pr2338.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2338.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://kesaseteli-youth-pr2338.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-youth-ui-pr2338.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-admin-ui-pr2338.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-youth-pr2338.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr2338.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-employer-pr2338.dev.hel.ninja 😆🎉🎉🎉

@sonarqubecloud
Copy link

[yjdh-tet-admin] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 98 Code Smells

71.2% 71.2% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[yjdh-kesaseteli-api] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 1 Bug
Vulnerability A 1 Vulnerability
Security Hotspot A 0 Security Hotspots
Code Smell A 62 Code Smells

94.5% 94.5% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[yjdh-tet-shared] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 42 Code Smells

42.8% 42.8% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[yjdh-tet-youth] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 61 Code Smells

29.0% 29.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 34 Code Smells

71.0% 71.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[yjdh-kesaseteli-youth] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

91.8% 91.8% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://kesaseteli-handler-pr2338.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://kesaseteli-youth-pr2338.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2338.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://tet-pr2338.api.dev.hel.ninja/healthz 🚀🚀🚀

@sonarqubecloud
Copy link

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

88.3% 88.3% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2338.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2338.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2338.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr2338.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-handler-pr2338.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

ADMIN branch is deployed to platta: https://tet-admin-ui-pr2338.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2338.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://tet-youth-ui-pr2338.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-employer-pr2338.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-admin-ui-pr2338.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-youth-ui-pr2338.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr2338.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-youth-pr2338.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2338.dev.hel.ninja 😆🎉🎉🎉

@sirtawast sirtawast merged commit ccbed72 into main Oct 16, 2023
173 checks passed
@sirtawast sirtawast deleted the hl-936-rebase branch October 16, 2023 07:25
This was referenced Oct 16, 2023
Closed
Closed
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjturt mjturt Awaiting requested review from mjturt

@rikuke rikuke Awaiting requested review from rikuke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sirtawast @terovirtanen