Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow applicant messages for all but cancelled and archived app (HL-860) #2496

Merged
merged 1 commit into from
Nov 22, 2023
Merged

fix: allow applicant messages for all but cancelled and archived app (HL-860) #2496

merged 1 commit into from
Nov 22, 2023

Conversation

sirtawast
Copy link
Collaborator

@sirtawast sirtawast commented Nov 17, 2023 •
edited
Loading

Description ✨

  • Add more statuses to be ok'd for messaging
  • If archived then no message can be sent by applicant
  • Fix/add tests for these cases

@sirtawast sirtawast requested a review from rikuke November 17, 2023 13:32
@sirtawast sirtawast changed the title fix: allow applicant messages for all but cancelled and archived app fix: allow applicant messages for all but cancelled and archived app (HL-860) Nov 20, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 142 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 304 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

77.1% 77.1% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2496.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2496.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2496.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2496.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2496.dev.hel.ninja 😆🎉🎉🎉

@sirtawast sirtawast merged commit 968ec9d into main Nov 22, 2023
62 checks passed
@sirtawast sirtawast deleted the hl-860 branch November 22, 2023 07:21
@github-actions github-actions bot mentioned this pull request Nov 22, 2023
Merged
@github-actions github-actions bot mentioned this pull request Dec 8, 2023
Merged
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikuke rikuke rikuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirtawast @terovirtanen @rikuke