Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show rejected in archive (HL-1039) #2588

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix: show rejected in archive (HL-1039) #2588

merged 1 commit into from
Dec 15, 2023

Conversation

mjturt
Copy link
Contributor

@mjturt mjturt commented Dec 7, 2023

Description ✨

Rejected are not sent to Talpa, so the status for them isn't SENT_TO_TALPA and so the archived is staying false. Now also set archived=true for rejected. Haven't worked with Talpa stuff before, can this interfere with something?

@mjturt mjturt requested review from sirtawast and rikuke December 7, 2023 14:27
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2588.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2588.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2588.dev.hel.ninja 😆🎉🎉🎉

@sirtawast
Copy link
Collaborator

sirtawast commented Dec 8, 2023

We need a new state probably as there is one too few. We just decided on this in todays daily. Also, the whole decision process has to be double checked on assertion that AHJO's BatchStatus.DECISION_REJECTED probably does not equal to ApplicationStatus.REJECTED (suggesting that rejected applications can have both accepted/rejected ahjo decision).

@mjturt
Copy link
Contributor Author

mjturt commented Dec 8, 2023

We need a new state probably as there is one too few. We just decided on this in todays daily. Also, the whole decision process has to be double checked on assertion that AHJO's BatchStatus.DECISION_REJECTED probably does not equal to ApplicationStatus.REJECTED (suggesting that rejected applications can have both accepted/rejected ahjo decision).

OK, thanks. Then we should probably expand the scope of this ticket. Let's discuss next week.

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2588.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr2588.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2588.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr2588.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2588.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr2588.dev.hel.ninja 😿💢💥💥

Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

The SonarCloud Quality Gate passed, but some issues were introduced.

9 New issues
0 Security Hotspots
86.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2588.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2588.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2588.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2588.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2588.dev.hel.ninja 😆🎉🎉🎉

@mjturt mjturt merged commit b1fd901 into main Dec 15, 2023
64 checks passed
@mjturt mjturt deleted the hl-1039 branch December 15, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants