Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 2nd instalment due date into csv #3635

Merged
merged 3 commits into from
Dec 5, 2024
Merged

feat: 2nd instalment due date into csv #3635

merged 3 commits into from
Dec 5, 2024

Conversation

rikuke
Copy link
Collaborator

@rikuke rikuke commented Dec 5, 2024

Description ✨

HL-1576
Add new columns to handler csv reports and PowerBI report:

  • the decided amount for instalment 1 and 2
  • the actual payable amount for instalment 2
  • the due date of instalment 2

Should fix HL-1571 also.

Change pruned_applications_csv_service to talpa_applications_csv in tests, because the name was confusing.

Use the recovered_amount property of instalment in talpa CSV export and the other csv reports.

Issues 🐛

Testing ⚗️

Screenshots 📸

Additional notes 🗒️

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3635.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3635.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3635.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3635.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3635.dev.hel.ninja 😆🎉🎉🎉

Copy link

sonarcloud bot commented Dec 5, 2024

Copy link

sonarcloud bot commented Dec 5, 2024

Copy link

sonarcloud bot commented Dec 5, 2024

Copy link

sonarcloud bot commented Dec 5, 2024

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3635.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3635.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3635.dev.hel.ninja 🚀🚀🚀

@rikuke rikuke requested a review from sirtawast December 5, 2024 10:05
@rikuke rikuke marked this pull request as ready for review December 5, 2024 10:06
@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3635.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3635.dev.hel.ninja 😆🎉🎉🎉

@rikuke rikuke merged commit f9bbaf9 into main Dec 5, 2024
64 checks passed
@rikuke rikuke deleted the HL-1576-csv branch December 5, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants