Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try to parse all kinds of ahjo errors #3639

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix: try to parse all kinds of ahjo errors #3639

merged 1 commit into from
Dec 9, 2024

Conversation

sirtawast
Copy link
Collaborator

@sirtawast sirtawast commented Dec 5, 2024

Description ✨

Ahjo error, depending on the case, might be inside an array, object, or string.

Try mapping as array first:[{"id": 1234, "message":"Hello ErrorArray}]

Next, try as object: {"id": 1234, "message": "Hello ErrorObject"}

Finally, fallback to string: "Hello ErrorString"

All of these 3 cases are possible to store into backend database.

@sirtawast sirtawast requested a review from rikuke December 5, 2024 13:30
Copy link

sonarcloud bot commented Dec 5, 2024

Copy link

sonarcloud bot commented Dec 5, 2024

Copy link

sonarcloud bot commented Dec 5, 2024

Copy link

sonarcloud bot commented Dec 5, 2024

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3639.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3639.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3639.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3639.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3639.dev.hel.ninja 😆🎉🎉🎉

@rikuke rikuke merged commit eb0f8be into main Dec 9, 2024
65 checks passed
@rikuke rikuke deleted the hl-1567 branch December 9, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants