Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/import living conditions question #12

Closed
wants to merge 4 commits into from

Conversation

juuso-j
Copy link
Collaborator

@juuso-j juuso-j commented Feb 12, 2024

Import living conditions question

Description

Trello #59

Breakdown:

Files changed

  1. media/questions.xlsx
    • Fix question 16 and some minor errors
  2. profiles/admin.py
    • Display 'fi' fields
  3. profiles/management/commands/import_questions.py
    • Iterate completly through the sheet, but skip some questions
  4. profiles/tests/test_import_questions.py
    • Test skip questions

@juuso-j juuso-j added bug Something isn't working enhancement New feature or request labels Feb 12, 2024
@juuso-j juuso-j requested a review from ezkat February 12, 2024 08:52
@juuso-j juuso-j self-assigned this Feb 12, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4bf5153) 92.17% compared to head (c7f9a3b) 92.24%.

Files Patch % Lines
profiles/admin.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #12      +/-   ##
===========================================
+ Coverage    92.17%   92.24%   +0.07%     
===========================================
  Files           59       59              
  Lines         2184     2193       +9     
  Branches       143      145       +2     
===========================================
+ Hits          2013     2023      +10     
  Misses         138      138              
+ Partials        33       32       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juuso-j juuso-j closed this Feb 13, 2024
@juuso-j juuso-j deleted the feature/import-living-conditions-question branch February 13, 2024 10:26
@juuso-j juuso-j restored the feature/import-living-conditions-question branch February 15, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants